Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-552: Test panic with finalized blocks after switch to pos #1163

Closed
wants to merge 9 commits into from
Closed

CSUB-552: Test panic with finalized blocks after switch to pos #1163

wants to merge 9 commits into from

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@github-actions
Copy link

For full LLVM coverage report click here!

@atodorov
CI: Build creditcoin-node independently and then use it
5fa38c3 
future CI jobs will also need the binary so it makes sense to split the
build process
@atodorov atodorov force-pushed the testing/CSUB-552-panic-with-finalized-blocks-after-switch-to-pos branch 2 times, most recently from 5b351a6 to fb7beff Compare June 28, 2023 17:58
@atodorov atodorov force-pushed the testing/CSUB-552-panic-with-finalized-blocks-after-switch-to-pos branch 13 times, most recently from 17f9fba to 767b942 Compare June 29, 2023 12:16
@atodorov atodorov force-pushed the testing/CSUB-552-panic-with-finalized-blocks-after-switch-to-pos branch from 767b942 to 1d4fc22 Compare June 29, 2023 12:47
@atodorov
Copy link
Contributor Author

Failing test job b/c of panic in Node2:
https://github.com/gluwa/creditcoin/actions/runs/5412361975/jobs/9836740684

@atodorov atodorov closed this Jul 10, 2023
@atodorov atodorov deleted the testing/CSUB-552-panic-with-finalized-blocks-after-switch-to-pos branch July 10, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atodorov @nathanwhit