Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert 0 to perbill - make it consistent with commands/validate #1188

Closed
wants to merge 1 commit into from

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Jul 3, 2023

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov requested a review from pLabarta July 3, 2023 16:21
@atodorov atodorov marked this pull request as ready for review July 3, 2023 16:21
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

For full LLVM coverage report click here!

@codecov-commenter
Copy link

Codecov Report

Merging #1188 (ad995a6) into dev (f37d28f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1188   +/-   ##
=======================================
  Coverage   74.62%   74.62%           
=======================================
  Files          74       74           
  Lines       10686    10686           
=======================================
  Hits         7974     7974           
  Misses       2712     2712           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atodorov atodorov closed this Jul 6, 2023
@atodorov atodorov deleted the cc-cli-wizard_commission branch July 6, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants