-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSUB-638: Add chain/era info to the Status command #1201
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1201 +/- ##
==========================================
- Coverage 69.50% 69.34% -0.16%
==========================================
Files 100 101 +1
Lines 11877 11904 +27
Branches 89 97 +8
==========================================
Hits 8255 8255
- Misses 3622 3649 +27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For full LLVM coverage report click here! |
159e347
to
2796c6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some questions, possibly need changes.
b607f01
to
fdddb69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall everything looks good to me. It might make sense to rename the cc-cli/src/utils
directory to cc-cli/src/lib
to reflect the growing importance of that part of the code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7267248
to
0805e8b
Compare
* add: add --chain & --validator flag to status * rename status util to validatorStatus * rename getStatus to getValidatorStatus * add: implement cli-table for validatorStatus
* add: add --chain & --validator flag to status * rename status util to validatorStatus * rename getStatus to getValidatorStatus * add: implement cli-table for validatorStatus
* add: add --chain & --validator flag to status * rename status util to validatorStatus * rename getStatus to getValidatorStatus * add: implement cli-table for validatorStatus
* add: add --chain & --validator flag to status * rename status util to validatorStatus * rename getStatus to getValidatorStatus * add: implement cli-table for validatorStatus
Description of proposed changes
This PR makes some changes to the
status
command to introduce an option to show the Chain's status.New behavior:
no flags
, it will just print the chain status (block tip, last finalized, era info)--validator [address]
flag, it will show that validator status--validator [address] --chain
, it will show information about both the chain and the validatorPractical tips for PR review & merge: