Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 226 #1254

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Update version to 226 #1254

merged 1 commit into from
Aug 14, 2023

Conversation

nathanwhit
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

Codecov Report

Merging #1254 (1f2f478) into dev (73e779f) will decrease coverage by 61.52%.
Report is 1 commits behind head on dev.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev   #1254       +/-   ##
==========================================
- Coverage   69.72%   8.20%   -61.52%     
==========================================
  Files         103      28       -75     
  Lines       12028     902    -11126     
  Branches      112     112               
==========================================
- Hits         8386      74     -8312     
+ Misses       3633     828     -2805     
+ Partials        9       0        -9     

see 83 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nathanwhit nathanwhit merged commit e458649 into dev Aug 14, 2023
31 of 32 checks passed
@nathanwhit nathanwhit deleted the version-bump-226 branch August 14, 2023 19:15
@github-actions
Copy link

For full LLVM coverage report click here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants