-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSUB-518: GATE -> CTC Swap #1256
Conversation
6445e69
to
fe0e615
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1256 +/- ##
==========================================
- Coverage 69.92% 8.20% -61.72%
==========================================
Files 103 28 -75
Lines 12098 902 -11196
Branches 112 112
==========================================
- Hits 8459 74 -8385
+ Misses 3630 828 -2802
+ Partials 9 0 -9 see 83 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For full LLVM coverage report click here! |
812f664
to
93276f1
Compare
…to not conflict with the gate token test
for more information, see https://pre-commit.ci
integration-tests/src/ethereum/ctc/contracts/GluwaGateToken.sol/GluwaGateToken.dbg.json
Outdated
Show resolved
Hide resolved
…ally allow for preexisting addresses for testing on testnet and mainnet
…s change in collect-coins-test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a few more unit tests (+ a few more not listed) but I can work on those once this ticket lands in READY FOR QA.
…t and set_burn_gate_contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is off with integration-test-loan-cycle
. I am currently debugging to see why it fails and will post my findings here, when ready.
Meanwhile I think we should not merge with a failing CI job, especially when not needed for the upcoming release.
Description of proposed changes
Practical tips for PR review & merge: