Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-518: GATE -> CTC Swap #1256

Closed
wants to merge 37 commits into from
Closed

CSUB-518: GATE -> CTC Swap #1256

wants to merge 37 commits into from

Conversation

zacharyfrederick
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@zacharyfrederick zacharyfrederick changed the title Csub 518 CSUB-518: GATE -> CTC Swap Aug 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #1256 (b4f6d40) into dev (0f33230) will decrease coverage by 61.72%.
Report is 3 commits behind head on dev.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev   #1256       +/-   ##
==========================================
- Coverage   69.92%   8.20%   -61.72%     
==========================================
  Files         103      28       -75     
  Lines       12098     902    -11196     
  Branches      112     112               
==========================================
- Hits         8459      74     -8385     
+ Misses       3630     828     -2802     
+ Partials        9       0        -9     

see 83 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

For full LLVM coverage report click here!

integration-tests/src/ctc-deploy.ts Outdated Show resolved Hide resolved
integration-tests/src/ctc-deploy.ts Outdated Show resolved Hide resolved
integration-tests/src/test/collect-coins.test.ts Outdated Show resolved Hide resolved
integration-tests/src/test/gate-token.test.ts Outdated Show resolved Hide resolved
integration-tests/src/test/gate-token.test.ts Outdated Show resolved Hide resolved
integration-tests/src/test/set-burn-gate-contract.test.ts Outdated Show resolved Hide resolved
integration-tests/src/test/gate-token.test.ts Outdated Show resolved Hide resolved
…ally allow for preexisting addresses for testing on testnet and mainnet
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a few more unit tests (+ a few more not listed) but I can work on those once this ticket lands in READY FOR QA.

pallets/creditcoin/src/tests.rs Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Outdated Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is off with integration-test-loan-cycle. I am currently debugging to see why it fails and will post my findings here, when ready.

Meanwhile I think we should not merge with a failing CI job, especially when not needed for the upcoming release.

@atodorov atodorov closed this Sep 19, 2023
@atodorov atodorov deleted the csub-518 branch September 19, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants