Update testnet to 2.230.0

.github/workflows/runtime-upgrade.yml

@@ -100,7 +100,6 @@ jobs:
           path: "last-block*"
           if-no-files-found: error
 
-
   build-sut:
     runs-on: ubuntu-22.04
 
@@ -131,7 +130,7 @@ jobs:
         uses: actions-rs/cargo@v1
         with:
           command: build
-          args: --release --features try-runtime
+          args: --release --features "fast-runtime try-runtime"
 
       - name: Upload creditcoin-node binary
         uses: actions/upload-artifact@v3
@@ -731,13 +730,16 @@ jobs:
             --chain ${{ needs.setup.outputs.target_chain }} \
             --validator --mining-key 5DkPYq8hFiCeGxFBkz6DAwnTrvKevAJfTYrzFtr9hpDsEAU1 \
             --bootnodes "${{ needs.setup.outputs.boot_node }}" \
+            --rpc-max-request-size 100000 \
+            --rpc-max-response-size 100000 \
             --prometheus-external \
             --telemetry-url "wss://telemetry.creditcoin.network/submit/ 0" \
             --public-addr "/dns4/$IP_ADDRESS/tcp/30333" >creditcoin-node-used-for-try-runtime.log 2>&1 &
 
       - name: Wait for creditcoin-node to initialize
         run: |
           ./integration-tests/wait-for-creditcoin.sh
+          ./scripts/wait-for-sync.sh ${{ needs.setup.outputs.last_block_number }}
 
       - name: Try-runtime migrations
         run: |

Cargo.toml

@@ -23,7 +23,7 @@ members = [
 resolver = "2"
 
 [workspace.package]
-version = '2.226.0'
+version = '2.230.0'
 authors = ['Gluwa Inc.', 'Nathan Whitaker <nathan.whitaker@gluwa.com>']
 edition = '2021'
 license = 'Unlicense'

chainspecs/mainnetSpec.json

@@ -11,7 +11,13 @@
     "tokenSymbol": "CTC"
   },
   "consensusEngine": null,
-  "grandpaInitialAuthorities": [],
+  "grandpaInitialAuthorities": [
+    "5FtSgXjm4RaWqjoGRoQjXxsmzPvnVJh9rYXU6pu8YRLXqHca",
+    "5FSmf1rrwb6jHzZBbHnVNk5zYFjn367Yn1ruMf8AVs3PX2kN",
+    "5D4yMa9ZDCiNxHDDQfs1jWWKvn7RC75ELHUXz92cEhWFhnx7",
+    "5D8Xv4ghgYSkTjUD11jZvpdiAPXZDDTbGfdrhGBpwEY8NmaD",
+    "5HDnRvFZ1VTMrgWEuCNa6EUpJeJZuVQqWTEnJtPCWywGJ2K5"
+  ],
   "codeSubstitutes": {},
   "badBlocks": null,
   "genesis": {

ci/env

@@ -1,3 +1,3 @@
 #!/bin/sh
 
-export RUSTC_VERSION=nightly-2023-04-16
+export RUSTC_VERSION=nightly-2023-06-06

creditcoin-js/package.json

@@ -15,7 +15,7 @@
         "generate:meta": "ts-node --skip-project node_modules/.bin/polkadot-types-from-chain --package creditcoin-js/interfaces  --endpoint ./creditcoin.json --output ./src/interfaces",
         "format": "prettier --write \"src/**/*.ts\"",
         "check-format": "prettier --check \"src/**/*.ts\"",
-        "lint": "eslint -c .eslintrc.js --ext .ts ./src",
+        "lint": "eslint -c .eslintrc.js --max-warnings 0 --ext .ts ./src",
         "typecheck": "tsc --noEmit",
         "prepare": "yarn build",
         "test": "$npm_execpath example"

creditcoin-js/src/types.ts

@@ -19,7 +19,6 @@ import {
     TransferId,
     TransferKind,
     TransferProcessed,
-    SignatureType,
     OwnershipProof,
 } from './model';
 import { AddressRegistered } from './extrinsics/register-address';
@@ -32,10 +31,7 @@ import { TransferEvent } from './extrinsics/register-transfers';
 import { LoanExempted } from './extrinsics/exempt';
 import { Wallet } from 'ethers';
 import { CollectCoinsEvent } from './extrinsics/request-collect-coins';
-import {
-    PalletCreditcoinOcwErrorsVerificationFailureCause,
-    PalletCreditcoinOwnershipProof,
-} from '@polkadot/types/lookup';
+import { PalletCreditcoinOcwErrorsVerificationFailureCause } from '@polkadot/types/lookup';
 
 export type TxCallback = (result: SubmittableResult) => void;
 export type TxFailureCallback = (error?: Error) => void;

integration-tests/package.json

@@ -6,7 +6,7 @@
     "scripts": {
         "test:comments": "--runInBand avoids race conditions with global setup",
         "test": "jest --silent --runInBand",
-        "lint": "eslint -c .eslintrc.js --ext .ts ./src",
+        "lint": "eslint -c .eslintrc.js --max-warnings 0 --ext .ts ./src",
         "format": "prettier --write \"src/**/*.ts\"",
         "check-format": "prettier --check \"src/**/*.ts\"",
         "typecheck": "tsc --noEmit"

pallets/creditcoin/src/ocw/tasks/collect_coins.rs

@@ -644,6 +644,23 @@ pub(crate) mod tests {
 		});
 	}
 
+	#[test]
+	fn request_collect_coins_should_fail_when_not_signed() {
+		let ext = ExtBuilder::default();
+		ext.build_offchain_and_execute_with_state(|_, _pool| {
+			let (_, addr, _, _) = generate_address_with_proof("collector");
+
+			assert_noop!(
+				Creditcoin::<Test>::request_collect_coins(
+					RuntimeOrigin::none(),
+					addr,
+					TX_HASH.hex_to_address(),
+				),
+				BadOrigin
+			);
+		});
+	}
+
 	#[test]
 	fn request_persisted_not_reentrant() {
 		let mut ext = ExtBuilder::default();

pallets/creditcoin/src/tests.rs

@@ -1300,7 +1300,7 @@ fn fund_deal_order_should_error_when_transfer_sighash_doesnt_match_lender() {
 
 		// modify transfer in order to cause transfer mismatch
 		crate::Transfers::<Test>::mutate(&transfer_id, |transfer_storage| {
-			let mut ts = transfer_storage.as_mut().unwrap();
+			let ts = transfer_storage.as_mut().unwrap();
 			// b/c amount above is 0
 			ts.amount = deal_order.terms.amount;
 			ts.account_id = AccountId::new([4; 32]);
@@ -1327,7 +1327,7 @@ fn fund_deal_order_should_error_when_transfer_has_been_processed() {
 
 		// modify transfer in order to cause an error
 		crate::Transfers::<Test>::mutate(&transfer_id, |transfer_storage| {
-			let mut ts = transfer_storage.as_mut().unwrap();
+			let ts = transfer_storage.as_mut().unwrap();
 			// b/c amount above is 0
 			ts.amount = deal_order.terms.amount;
 			ts.is_processed = true;
@@ -2134,7 +2134,7 @@ fn close_deal_order_should_error_when_transfer_block_is_greater_than_current_blo
 
 		// modify transfer in order to cause transfer mismatch
 		crate::Transfers::<Test>::mutate(&transfer_id, |transfer_storage| {
-			let mut ts = transfer_storage.as_mut().unwrap();
+			let ts = transfer_storage.as_mut().unwrap();
 			// b/c amount above is 0
 			ts.amount = deal_order.terms.amount;
 			ts.block = Creditcoin::block_number() + 1;
@@ -2172,7 +2172,7 @@ fn close_deal_order_should_error_when_transfer_sighash_doesnt_match_borrower() {
 
 		// modify transfer in order to cause transfer mismatch
 		crate::Transfers::<Test>::mutate(&transfer_id, |transfer_storage| {
-			let mut ts = transfer_storage.as_mut().unwrap();
+			let ts = transfer_storage.as_mut().unwrap();
 			ts.account_id = AccountId::new([44; 32]);
 		});
 
@@ -2208,7 +2208,7 @@ fn close_deal_order_should_error_when_transfer_has_already_been_processed() {
 
 		// modify transfer in order to cause transfer mismatch
 		crate::Transfers::<Test>::mutate(&transfer_id, |transfer_storage| {
-			let mut ts = transfer_storage.as_mut().unwrap();
+			let ts = transfer_storage.as_mut().unwrap();
 			// b/c amount above is 0
 			ts.is_processed = true;
 		});
@@ -2261,7 +2261,7 @@ fn close_deal_order_should_succeed() {
 
 		// modify transfer to make sure we have transfered enough funds
 		crate::Transfers::<Test>::mutate(&transfer_id, |transfer_storage| {
-			let mut ts = transfer_storage.as_mut().unwrap();
+			let ts = transfer_storage.as_mut().unwrap();
 
 			ts.amount = deal_order.terms.amount + 1u64;
 		});

runtime/src/lib.rs

@@ -734,41 +734,6 @@ where
 	}
 }
 
-// Create the runtime by composing the FRAME pallets that were previously configured.
-construct_runtime!(
-	pub enum Runtime where
-		Block = Block,
-		NodeBlock = opaque::Block,
-		UncheckedExtrinsic = UncheckedExtrinsic
-	{
-		System: frame_system,
-		Timestamp: pallet_timestamp,
-		PosSwitch: pallet_pos_switch,
-		Babe: pallet_babe,
-		Balances: pallet_balances,
-		Authorship: pallet_authorship,
-		Staking: pallet_staking_substrate,
-		Offences: pallet_offences,
-		Historical: session_historical,
-		Session: pallet_session,
-		Grandpa: pallet_grandpa,
-		ImOnline: pallet_im_online,
-		VoterList: pallet_bags_list::<Instance1>,
-		TransactionPayment: pallet_transaction_payment,
-		Sudo: pallet_sudo,
-		Creditcoin: pallet_creditcoin,
-		Difficulty: pallet_difficulty,
-		Rewards: pallet_rewards,
-		Scheduler: pallet_scheduler,
-		TaskScheduler: pallet_offchain_task_scheduler,
-		Identity: pallet_identity,
-		Utility: pallet_utility,
-		Proxy: pallet_proxy,
-		FastUnstake: pallet_fast_unstake,
-		NominationPools: pallet_nomination_pools,
-	}
-);
-
 /// The address format for describing accounts.
 pub type Address = sp_runtime::MultiAddress<AccountId, ()>;
 /// Block header type as expected by this runtime.
@@ -1187,3 +1152,38 @@ impl pallet_nomination_pools::Config for Runtime {
 	type MaxMetadataLen = ();
 	type MaxUnbonding = MaxUnbonding;
 }
+
+// Create the runtime by composing the FRAME pallets that were previously configured.
+construct_runtime!(
+	pub enum Runtime where
+		Block = Block,
+		NodeBlock = opaque::Block,
+		UncheckedExtrinsic = UncheckedExtrinsic
+	{
+		System: frame_system,
+		Timestamp: pallet_timestamp,
+		PosSwitch: pallet_pos_switch,
+		Babe: pallet_babe,
+		Balances: pallet_balances,
+		Authorship: pallet_authorship,
+		Staking: pallet_staking_substrate,
+		Offences: pallet_offences,
+		Historical: session_historical,
+		Session: pallet_session,
+		Grandpa: pallet_grandpa,
+		ImOnline: pallet_im_online,
+		VoterList: pallet_bags_list::<Instance1>,
+		TransactionPayment: pallet_transaction_payment,
+		Sudo: pallet_sudo,
+		Creditcoin: pallet_creditcoin,
+		Difficulty: pallet_difficulty,
+		Rewards: pallet_rewards,
+		Scheduler: pallet_scheduler,
+		TaskScheduler: pallet_offchain_task_scheduler,
+		Identity: pallet_identity,
+		Utility: pallet_utility,
+		Proxy: pallet_proxy,
+		FastUnstake: pallet_fast_unstake,
+		NominationPools: pallet_nomination_pools,
+	}
+);

runtime/src/version.rs

@@ -14,7 +14,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
 	//   `spec_version`, and `authoring_version` are the same between Wasm and native.
 	// This value is set to 100 to notify Polkadot-JS App (https://polkadot.js.org/apps) to use
 	//   the compatible custom types.
-	spec_version: 226,
+	spec_version: 230,
 	impl_version: 0,
 	apis: RUNTIME_API_VERSIONS,
 	transaction_version: 11,

scripts/cc-cli/.eslintrc.js

@@ -86,7 +86,7 @@ module.exports = {
         format: ["strictCamelCase"],
         filter: {
           // you can expand this regex to add more allowed names
-          regex: "^(CC_SEED|CC_CONTROLLER_SEED|CC_STASH_SEED)$",
+          regex: "^(CC_SECRET|CC_CONTROLLER_SECRET|CC_STASH_SECRET)$",
           match: false,
         },
       },