CSUB-692: try-runtime test w/o fast-runtime #1269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
older version panics when compiling creditcoin-transaction-producer, this one seems to work
* add: replace getSeed with initKeyring funcs that support ecdsa * implement initKeyring in bond * implement initKeyring in show-address * implement initKeyring in chill * implement initKeyring in distribute-rewards * implement initKeyring in send * implement initKeyring in set-keys * make --ecdsa a global flag * implement initKeyring in unbond * implement initKeyring in validate * implementinitKeyring in withdraw * implement initKeyring in wizard * remove unused imports * yarn format * yarn format #2 * add ecdsa tests to integration-tests * Auto-update creditcoin-js type definitions * add CC_PK to camelCase exceptions * remove unused import * fix: was using older prettier version * keep envVar consistent when using ecdsa * add: ecdsa key validation * update and split tests * format *sigh* * Auto-update creditcoin-js type definitions * remove unused imports and vars * add: randomTestAccount helper * upgrade wizard test to cover ecdsa/phrase * upgrade showAddress test to use randomTestAccount * use randomTestAccount in send test * export validateECDSAKey * upgrade validatorCycle test to cover ecdsa * fix: formatting, finally * fix: bad params in prompt command * Treat eslint warnings as errors & exit 1 things like unused imports are warnings and easlint will exit with 0 so we don't get to notice them! This change will cause CI jobs to fail so that we can notice these issues and fix them! * Remove unused imports * appease linter * replace switch with if Co-authored-by: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> --------- Co-authored-by: gluwa-bot <creditcoin@gluwa.com> Co-authored-by: Alex Todorov <alex.todorov@gluwa.com> Co-authored-by: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com>
Co-authored-by: Ada <> Co-authored-by: gluwa-bot <creditcoin@gluwa.com> Co-authored-by: Nathan Whitaker <nathan.whitaker01@gmail.com>
|
For full LLVM coverage report click here! |
atodorov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Practical tips for PR review & merge: