-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSUB-518: Pt. 1 - introduced set_gate_contract #1275
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1275 +/- ##
==========================================
- Coverage 70.06% 8.32% -61.74%
==========================================
Files 103 28 -75
Lines 12095 889 -11206
Branches 114 114
==========================================
- Hits 8474 74 -8400
+ Misses 3612 815 -2797
+ Partials 9 0 -9 see 83 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For full LLVM coverage report click here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some adjustments for tests, otherwise looks good.
Note: I will merge the suggestions & squash some of the commits in the interest of fast turnaround time.
in preparation for request_collect_coins_v2
- fix initial WeightInfo to be greater than zero before benchmarks have the chance to update this appropriately
a190be7
to
f322646
Compare
Looks good to me, thanks for splitting it up |
This PR makes several important changes:
set_gate_contract
extrinsicGCreContract
type toDeployedContract
.Rationale:
request_collect_coins
implementation is built entirely around the GCRE contract. This change will be more relevant when therequest_collect_coins_v2
extrinsic is introduced.Tests for
set_burn_gate_contract