Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-698: Bump version to 2.230.1 for mainnet #1285

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

atodorov
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #1285 (c3c61a4) into main (610134c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1285   +/-   ##
=======================================
  Coverage   70.06%   70.06%           
=======================================
  Files         103      103           
  Lines       12095    12095           
  Branches      114      114           
=======================================
  Hits         8474     8474           
  Misses       3612     3612           
  Partials        9        9           
Files Changed Coverage Δ
runtime/src/version.rs 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov merged commit 08a8d22 into main Aug 28, 2023
36 of 37 checks passed
@atodorov atodorov deleted the testing/CSUB-698-bump-version-for-mainnet branch August 28, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants