Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSUB-845][hotfix] Split cleanup of expired entries across multiple blocks #1352

Merged
merged 12 commits into from
Oct 9, 2023

Conversation

nathanwhit
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2023

Codecov Report

Merging #1352 (a59e86e) into main (1aa0996) will increase coverage by 2.17%.
The diff coverage is 97.34%.

@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   68.93%   71.11%   +2.17%     
==========================================
  Files         103      106       +3     
  Lines       12095    12470     +375     
  Branches      114      114              
==========================================
+ Hits         8338     8868     +530     
+ Misses       3757     3593     -164     
- Partials        0        9       +9     
Files Coverage Δ
pallets/creditcoin/src/mock.rs 100.00% <ø> (ø)
pallets/creditcoin/src/test_utils.rs 100.00% <100.00%> (ø)
pallets/creditcoin/src/tests.rs 98.20% <ø> (ø)
runtime/src/lib.rs 15.74% <100.00%> (-0.20%) ⬇️
runtime/src/version.rs 0.00% <ø> (ø)
pallets/creditcoin/src/lib.rs 87.18% <97.91%> (+1.85%) ⬆️
pallets/creditcoin/src/types.rs 83.00% <0.00%> (ø)
pallets/creditcoin/src/types/cleanup.rs 92.85% <92.85%> (ø)
pallets/creditcoin/src/tests/cleanup.rs 97.80% <97.80%> (ø)

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

For full LLVM coverage report click here!

@nathanwhit nathanwhit merged commit 15ae61d into main Oct 9, 2023
37 of 40 checks passed
@nathanwhit nathanwhit deleted the cleanup-across-blocks branch October 9, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants