Make test-migrations-via-try-runtime CI job depend on live-sync-credi… #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
testing/patch-try-runtime-migrations
branch
from
5824c80
to
70c3ae7
Compare
|
Successfull |
…tcoin
this should reuse the database which is already on-disk and not cause a
second sync, hopefully reducing the overall execution time for this CI
job.
Also specify missing `--pruning archive` option to deal with errors
like:
Error = Call(Custom(ErrorObject { code: ServerError(-32000), message: "Client error: UnknownBlock: State already discarded for 0x7a6052272f51d086f3c0f89ced306b845ba93465591026107c6e236174d993d4", data: None }))
atodorov
force-pushed
the
testing/patch-try-runtime-migrations
branch
from
70c3ae7
to
aa340a0
Compare
|
For full LLVM coverage report click here! |
Codecov Report
@@ Coverage Diff @@
## dev #1377 +/- ##
=======================================
Coverage 71.86% 71.86%
=======================================
Files 111 111
Lines 12953 12953
Branches 128 128
=======================================
Hits 9309 9309
Misses 3634 3634
Partials 10 10 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
zacharyfrederick
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tcoin
this should reuse the database which is already on-disk and not cause a second sync, hopefully reducing the overall execution time for this CI pipeline.
Also specify missing
--pruning archiveoption to deal with errors like:Error = Call(Custom(ErrorObject { code: ServerError(-32000), message: "Client error: UnknownBlock: State already discarded for 0x7a6052272f51d086f3c0f89ced306b845ba93465591026107c6e236174d993d4", data: None }))
Description of proposed changes
Practical tips for PR review & merge: