Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Cleanup across blocks into testnet branch #1387

Merged
merged 12 commits into from
Oct 31, 2023

Conversation

atodorov
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #1387 (aaa116c) into testnet (5d1572b) will decrease coverage by 0.01%.
The diff coverage is 96.07%.

@@             Coverage Diff             @@
##           testnet    #1387      +/-   ##
===========================================
- Coverage    71.17%   71.16%   -0.01%     
===========================================
  Files          107      110       +3     
  Lines        12498    12873     +375     
  Branches       120      120              
===========================================
+ Hits          8895     9161     +266     
- Misses        3593     3712     +119     
+ Partials        10        0      -10     
Files Coverage Δ
pallets/creditcoin/src/mock.rs 100.00% <ø> (ø)
pallets/creditcoin/src/test_utils.rs 100.00% <100.00%> (ø)
pallets/creditcoin/src/tests.rs 98.24% <ø> (ø)
runtime/src/version.rs 0.00% <ø> (ø)
pallets/creditcoin/src/lib.rs 84.97% <97.91%> (+1.78%) ⬆️
pallets/creditcoin/src/types.rs 83.07% <0.00%> (ø)
pallets/creditcoin/src/types/cleanup.rs 92.85% <92.85%> (ø)
pallets/creditcoin/src/tests/cleanup.rs 97.80% <97.80%> (ø)
runtime/src/lib.rs 17.11% <16.66%> (-0.24%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AdaJane
AdaJane previously approved these changes Oct 30, 2023
nathanwhit
nathanwhit previously approved these changes Oct 30, 2023
@github-actions
Copy link

For full LLVM coverage report click here!

@github-actions github-actions bot dismissed stale reviews from nathanwhit and AdaJane via 08ad291 October 30, 2023 22:28
@atodorov atodorov marked this pull request as ready for review October 31, 2023 09:47
@atodorov
Copy link
Contributor Author

Merging with some CI failures:

@atodorov atodorov merged commit e72ccfc into testnet Oct 31, 2023
1 check passed
@atodorov atodorov deleted the cleanup-across-blocks-dev branch October 31, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants