Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-861: Skip upgrade against disconnected nodes #1533

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

CSUB-861: Skip upgrade against disconnected nodes #1533

wants to merge 1 commit into from

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Feb 9, 2024

https://gluwa.atlassian.net/wiki/spaces/CB/pages/1119912022/Context+decision+for+CSUB-861+runtime+upgrade+testing+against+disconnected+node

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov changed the base branch from testnet to dev February 9, 2024 11:39
@atodorov atodorov force-pushed the testing/CSUB-861-skip-upgrade-against-disconnected branch from 73db4d2 to fcbd827 Compare February 9, 2024 11:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

For full LLVM coverage report click here!

@atodorov
Copy link
Contributor Author

atodorov commented Feb 9, 2024

Strangely enough the wasm upgrade on CC2 works, see:
https://github.com/gluwa/creditcoin/actions/runs/7843393955/job/21405343383

so maybe we don't merge this PR after all. WDYT ?

@atodorov atodorov marked this pull request as draft February 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyfrederick zacharyfrederick Awaiting requested review from zacharyfrederick

@pLabarta pLabarta Awaiting requested review from pLabarta

@frankli-dev frankli-dev Awaiting requested review from frankli-dev

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atodorov