Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow actions-rs/grcov to fail #1552

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Mar 1, 2024

because recently it started failing with:

Error: failed to compile grcov v0.8.19, intermediate artifacts can be found at /var/folders/h1/8hndypj13nsbj5pn4xsnv1tm0000gn/T/cargo-installyBLQUt
Caused by:
package clap_lex v0.7.0 cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.72.0-nightly
Try re-running cargo install with --locked

and this actions doesn't allow control over how cargo install is executed internally

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

because recently it started failing with:

  Error: failed to compile `grcov v0.8.19`, intermediate artifacts can be found at `/var/folders/h1/8hndypj13nsbj5pn4xsnv1tm0000gn/T/cargo-installyBLQUt`
  Caused by:
    package `clap_lex v0.7.0` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.72.0-nightly
    Try re-running cargo install with `--locked`

and this actions doesn't allow control over how `cargo install` is
executed internally
@atodorov atodorov merged commit fb2a9a4 into dev Mar 6, 2024
35 of 38 checks passed
@atodorov atodorov deleted the testing/allow-grcov-step-to-fail branch March 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants