Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1688

Merged
merged 1 commit into from
Aug 14, 2024
Merged

chore: fix some comments #1688

merged 1 commit into from
Aug 14, 2024

Conversation

bytetigers
Copy link
Contributor

Description of proposed changes

fix some comments


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

Signed-off-by: bytetigers <bytetiger@icloud.com>
@darrenvechain
Copy link

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.06%. Comparing base (0bc829f) to head (7861de2).
Report is 147 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1688       +/-   ##
===========================================
- Coverage   76.47%   48.06%   -28.42%     
===========================================
  Files          76      120       +44     
  Lines       11560     7798     -3762     
  Branches        0      181      +181     
===========================================
- Hits         8841     3748     -5093     
- Misses       2719     4011     +1292     
- Partials        0       39       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atodorov
Copy link
Contributor

@atodorov Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos.

@darrenvechain regardless of what it is the PR is still valid. I will leave the rest of the Creditcoin dev team to review but I don't see a problem merging it.

@bytetigers
Copy link
Contributor Author

@atodorov Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos.

@darrenvechain regardless of what it is the PR is still valid. I will leave the rest of the Creditcoin dev team to review but I don't see a problem merging it.

Thanks. I am not a bot.

@atodorov atodorov merged commit 89498fe into gluwa:dev Aug 14, 2024
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants