Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-959: Points to Balance conversion on Polkadot SDK #131

Closed
wants to merge 1 commit into from
Closed

CSUB-959: Points to Balance conversion on Polkadot SDK #131

wants to merge 1 commit into from

Conversation

frankli-dev
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@frankli-dev frankli-dev mentioned this pull request Dec 18, 2023
Merged
atodorov
atodorov requested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested but can be used for testing purposes as-is.

Cargo.toml
sc-transaction-pool = { version = "4.0.0-dev", git = "https://github.com/paritytech/polkadot-sdk", branch = "release-polkadot-v1.1.0" }
sc-transaction-pool-api = { version = "4.0.0-dev", git = "https://github.com/paritytech/polkadot-sdk", branch = "release-polkadot-v1.1.0" }
sc-utils = { version = "4.0.0-dev", git = "https://github.com/paritytech/polkadot-sdk", branch = "release-polkadot-v1.1.0" }
sc-basic-authorship = { version = "0.10.0-dev", git = "https://github.com/frankli-dev/polkadot-sdk", rev = "eb828ee49b9b7353aad4878428b87f41a4943841" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be under gluwa/polkadot-sdk but is good enough for testing purposes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the top of .github/check-for-used-forks.sh for the whitelist.

Cargo.toml
sc-utils = { version = "4.0.0-dev", git = "https://github.com/paritytech/polkadot-sdk", branch = "release-polkadot-v1.1.0" }
sc-basic-authorship = { version = "0.10.0-dev", git = "https://github.com/frankli-dev/polkadot-sdk", rev = "eb828ee49b9b7353aad4878428b87f41a4943841" }
sc-block-builder = { version = "0.10.0-dev", git = "https://github.com/frankli-dev/polkadot-sdk", rev = "eb828ee49b9b7353aad4878428b87f41a4943841" }
sc-chain-spec = { version = "4.0.0-dev", git = "https://github.com/frankli-dev/polkadot-sdk", rev = "eb828ee49b9b7353aad4878428b87f41a4943841" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a branch name, not an individual commit hash.

The branch name should allow to easily figure out which is the upstream branch. For example:
upstream is release-polkadot-v1.1.0 then downstream is something like release-polkadot-v1.1.0-fixes.

For example see https://github.com/gluwa/creditcoin/blob/dev/Cargo.toml#L65 and the pattern:

frame-benchmarking-cli = { branch = "pos-keep-history-polkadot-v0.9.41", git = "https://github.com/gluwa/substrate.git" }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is just for testing purposes. We will use branch name once we fork those repos under gluwa organization

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is just for testing purposes. We will use branch name once we fork those repos under gluwa organization

Sure. However once you fork and make the change to build against gluwa/polkadot-sdk we'll have to retest again in order to verify that we're building against the same target. So may as well make the fork now and save one round of the back & forth.

Worst case scenario we remove the branch in the forked repo (or the forked repo entirely) if the decision is made to go in a different direction.

@atodorov atodorov changed the title fix: Points to Balance conversion on Polkadot SDK CSUB-959: Points to Balance conversion on Polkadot SDK Dec 18, 2023
@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov deleted the fix/nomination-conversion branch March 19, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atodorov atodorov atodorov requested changes

@zacharyfrederick zacharyfrederick Awaiting requested review from zacharyfrederick

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

@pLabarta pLabarta Awaiting requested review from pLabarta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankli-dev @atodorov