Bump version to 3.12.0 (to trigger update with the patched polkadot-sdk) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For full LLVM coverage report click here! |
will require version bump whenever there's a change to any of the dependencies which are consumed via GitHub instead of crates.io
atodorov
force-pushed
the
update-with-patch
branch
from
f6144c3
to
19eda79
Compare
atodorov
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
When merging #132 we didn't actually update the runtime version, so no runtime upgrade actually happened!
Rebased to dev and added a change to the version check script to catch the use case where dependencies consumed from GitHub have changed.
pLabarta
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
When merging #132 we didn't actually update the runtime version, so no runtime upgrade actually happened!
Practical tips for PR review & merge: