Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-899: Add pallet_scheduler #168

Merged
merged 3 commits into from
Jan 17, 2024
Merged

CSUB-899: Add pallet_scheduler #168

merged 3 commits into from
Jan 17, 2024

Conversation

zacharyfrederick
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

Copy link

For full LLVM coverage report click here!

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's exercise this functionality during runtime upgrades for Devnet, see
https://github.com/gluwa/creditcoin3/blob/dev/.github/workflows/wasm.yml#L81

Replace 0 with any other positive integer (doesn't need to be 50 IMO, can be something as low as 5).

runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit to typedefs failed, https://github.com/gluwa/creditcoin3/actions/runs/7491379520/job/20392737262.

I think if you drop the existing automated commits and rebase the PR so that CI jobs execute again it will fix itself.

@atodorov
Copy link
Contributor

FTR rebased onto latest dev, dropped automated commits (will be regenerated) and squashed the first 2. Will approve and merge once CI jobs are passing.

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing for 75adbff. llvm-cov failure is a known one, needs update to Azure credentials.

Merging this PR.

@atodorov atodorov merged commit 66b7062 into dev Jan 17, 2024
1 check passed
@atodorov atodorov deleted the csub-899 branch January 17, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants