Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-1008: Updates around unsupported Windows platform #177

Merged
merged 3 commits into from
Jan 22, 2024
Merged

CSUB-1008: Updates around unsupported Windows platform #177

merged 3 commits into from
Jan 22, 2024

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov
Do not attach unsupported Windows binaries as release artifacts
a16daf1 
> The blockchain team takes the stance that running Creditcoin on Windows
> is officially unsupported and at best should be thought of as experimental.

See:
GHSA-cx5c-xwcv-vhmq
@atodorov
Add a note about Windows being unsupported
6c715a4
@atodorov
Update old reference to frontier in README
eda44a8
@atodorov atodorov force-pushed the release/CSUB-1008-windows-is-unsupported branch from ad1097a to eda44a8 Compare January 19, 2024 11:03
@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov merged commit 2cf39e0 into dev Jan 22, 2024
30 checks passed
@atodorov atodorov deleted the release/CSUB-1008-windows-is-unsupported branch January 22, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@pLabarta pLabarta pLabarta approved these changes

@zacharyfrederick zacharyfrederick Awaiting requested review from zacharyfrederick

@frankli-dev frankli-dev Awaiting requested review from frankli-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atodorov @pLabarta @nathanwhit