Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-849: Add checks for version & epoch duration; Dockerfile fixes & tests #22

Merged
merged 5 commits into from
Oct 13, 2023
Merged

CSUB-849: Add checks for version & epoch duration; Dockerfile fixes & tests #22

merged 5 commits into from
Oct 13, 2023

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov marked this pull request as ready for review October 13, 2023 12:35
@atodorov atodorov force-pushed the testing/CSUB-849-enable-ci-jobs branch from abd6a00 to c652aa0 Compare October 13, 2023 12:41
@atodorov atodorov changed the title CSUB-849: Add checks for version & epoch duration CSUB-849: Add checks for version & epoch duration; Dockerfile fixes & tests Oct 13, 2023
@atodorov
Make sure to build a docker image in CI
f161ac5 
additional tests will be added later
@atodorov
Ignore some warnings from gitleaks
551c9b8 
b/c these are all examples from README / Dev accounts
@atodorov atodorov merged commit c27a301 into dev Oct 13, 2023
9 of 11 checks passed
@atodorov atodorov deleted the testing/CSUB-849-enable-ci-jobs branch October 13, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdaJane AdaJane AdaJane approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

@zacharyfrederick zacharyfrederick Awaiting requested review from zacharyfrederick

@pLabarta pLabarta Awaiting requested review from pLabarta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atodorov @AdaJane