Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugging in Chainspecs for third CC3 mainnet dry run #425

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Plugging in Chainspecs for third CC3 mainnet dry run #425

merged 6 commits into from
Jul 30, 2024

Conversation

BradleyOlson64
Copy link
Contributor

No description provided.

@BradleyOlson64 BradleyOlson64 requested a review from a team as a code owner July 30, 2024 06:28
@BradleyOlson64 BradleyOlson64 requested review from AstonL and removed request for a team July 30, 2024 06:29
@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

atodorov
atodorov requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • address the failures in MegaLinter job
  • you may also run prettier against these JSON files to remove the warning

beqaabu
beqaabu reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@beqaabu beqaabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chainspec itself looks good. I think we can overwrite the old chainspec with the new one and not have too many chainspec files present in the repo. Other than that pls fix the ci for megalinter and should be good to go

@BradleyOlson64 BradleyOlson64 removed the request for review from AstonL July 30, 2024 17:33
@dlebee dlebee merged commit 42f7f8a into dev Jul 30, 2024
52 of 53 checks passed
@BradleyOlson64 BradleyOlson64 deleted the brad-dryrun-3 branch July 30, 2024 19:29
@atodorov atodorov mentioned this pull request Aug 1, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beqaabu beqaabu beqaabu left review comments

@atodorov atodorov atodorov requested changes

@dlebee dlebee dlebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BradleyOlson64 @atodorov @beqaabu @dlebee