Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-1234: More prep work around self-hosted runners #426

Merged
merged 4 commits into from
Aug 1, 2024
Merged

CSUB-1234: More prep work around self-hosted runners #426

merged 4 commits into from
Aug 1, 2024

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov requested a review from a team as a code owner July 31, 2024 09:24
@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

BradleyOlson64
BradleyOlson64 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@BradleyOlson64 BradleyOlson64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

beqaabu
beqaabu reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@beqaabu beqaabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Megalinter unhappy, otherwise looks good

@atodorov
Copy link
Contributor Author

atodorov commented Aug 1, 2024

Megalinter unhappy, otherwise looks good

Unrelated to this PR. Introduced in #425 and will be fixed y @BradleyOlson64 as a follow up.

@atodorov atodorov merged commit 2dbdb12 into dev Aug 1, 2024
52 of 53 checks passed
@atodorov atodorov deleted the testing/CSUB-1234-more-prep-work branch August 1, 2024 09:43
@atodorov atodorov restored the testing/CSUB-1234-more-prep-work branch August 1, 2024 09:44
@atodorov atodorov deleted the testing/CSUB-1234-more-prep-work branch August 1, 2024 09:47
@atodorov atodorov restored the testing/CSUB-1234-more-prep-work branch August 1, 2024 11:34
@atodorov atodorov deleted the testing/CSUB-1234-more-prep-work branch August 1, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beqaabu beqaabu beqaabu left review comments

@BradleyOlson64 BradleyOlson64 BradleyOlson64 approved these changes

@rustlang-dev rustlang-dev Awaiting requested review from rustlang-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atodorov @BradleyOlson64 @beqaabu