Final dry run spec files #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradleyOlson64
requested review from
jonZlotnik and
Retamogordo
and removed request for
a team
Closed
BradleyOlson64
requested review from
beqaabu,
rustlang-dev,
DylanVerstraete and
atodorov
and removed request for
jonZlotnik and
Retamogordo
|
For full LLVM coverage report click here! |
dlebee
approved these changes
Aug 13, 2024
beqaabu
approved these changes
Aug 13, 2024
dlebee
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specs had to be uploaded using Git lfs because they now contain balances for all .5 million accounts on the CC2 mainnet. They look like they were just removed here because GitHub doesn't provide large file visibility.
You can still download the files from this branch to check them locally.
Megalinter doesn't like the lfs file pointer being used, and I'm not sure how best to resolve that.
Also, will our image build be messed up by this? Or will it appropriately retrieve the full large file?
I noticed that after this change you only get the full dry run specs if you pull using
git lfs pull. Is that acceptable?