New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trying to make it use LFS everywhere where we use action checkout #443

Merged

dlebee merged 1 commit into dev from feature/fix-checkout-with-lfs

Aug 14, 2024

Contributor

dlebee commented Aug 14, 2024

Description of proposed changes

Practical tips for PR review & merge:

All GitHub Actions report PASS
Newly added code/functions have unit tests
- Coverage tools report all newly added lines as covered
- The positive scenario is exercised
- Negative scenarios are exercised, e.g. assert on all possible errors
- Assert on events triggered if applicable
- Assert on changes made to storage if applicable
Modified behavior/functions - try to make sure above test items are covered
Integration tests are added if applicable/needed


          trying to make it use LFS everywhere where we use action checkout

9e25eb9

dlebee requested a review from a team as a code owner

August 14, 2024 01:47

dlebee requested review from dave1374 and AstonL and removed request for a team and AstonL

August 14, 2024 01:47

dlebee merged commit ed50df3 into dev

35 checks passed

dlebee deleted the feature/fix-checkout-with-lfs branch

August 14, 2024 01:53

github-actions bot commented Aug 14, 2024

For full LLVM coverage report click here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet