fix: correct precompile interface and json abi #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanVerstraete
requested review from
dave1374 and
dlebee
and removed request for
a team
|
For full LLVM coverage report click here! |
atodorov
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Need to fix this as well:
https://github.com/gluwa/creditcoin3/actions/runs/10835800728/job/30068106861?pr=462
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
DylanVerstraete
requested review from
BradleyOlson64 and
beqaabu
and removed request for
dave1374
|
This will require a runtime upgrade, @atodorov do I bump the runtime version in this PR? Also how do I chain the mainnet json files? |
atodorov
requested changes
Sep 16, 2024
There was a problem hiding this comment.
This https://github.com/gluwa/creditcoin3/actions/runs/10853245614/job/30121104364?pr=462 requires a version bump.
atodorov
approved these changes
Sep 16, 2024
BradleyOlson64
approved these changes
Sep 16, 2024
beqaabu
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
fixes precompile interface and abi json