Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-1322: Include repository name as part of self-hosted runner hostname #508

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Oct 11, 2024

Description of proposed changes

Include the repository name as part of the self-hosted runner VM hostname, to make it easier to connect VM -> repository -> workflow:

Old names at top of image, new names below:
image

NOTE: the reported MegaLinter failure is unrelated, see #483 (comment)

NOTE: provisioning & running on Azure using the new naming scheme appears to be working as well, see:
https://github.com/gluwa/creditcoin3/actions/runs/11290155122/job/31401798798?pr=509


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

Copy link

For full LLVM coverage report click here!

@atodorov atodorov marked this pull request as ready for review October 11, 2024 10:27
@atodorov atodorov requested a review from a team as a code owner October 11, 2024 10:27
@atodorov atodorov merged commit d611382 into dev Oct 11, 2024
51 of 53 checks passed
@atodorov atodorov deleted the testing/CSUB-1322-prefix-self-hosted-with-repo-name branch October 11, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants