Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-1345: Replace Azure VMs with Linode VMs for runtime-upgrade CI jobs #522

Draft
wants to merge 1 commit into
base: testnet
Choose a base branch
from

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Nov 8, 2024

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov force-pushed the ci/CSUB-1345-migrate-away-from-azure branch 2 times, most recently from dbb6626 to 902f6c2 Compare November 8, 2024 13:34
Copy link

github-actions bot commented Nov 8, 2024

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the ci/CSUB-1345-migrate-away-from-azure branch from 902f6c2 to 3a9d1af Compare November 8, 2024 13:47
@atodorov atodorov force-pushed the ci/CSUB-1345-migrate-away-from-azure branch from 3a9d1af to 68b1325 Compare November 8, 2024 13:49
@atodorov
Copy link
Contributor Author

NOTE: https://github.com/gluwa/creditcoin3/actions/runs/11743345590/job/32728998589?pr=522 failed because the underlying VM was removed by https://github.com/gluwa/creditcoin3-next/actions/runs/11748027127/job/32731230248 b/c it has been over 5 hrs since the VM was launched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant