alchemy for large accounts #1278
Conversation
onemicky
commented
Sep 30, 2024
•
onemicky
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1208263214312296
✅ Deploy Preview for vigilant-albattani-df38ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying gmx-interface with
|
| Latest commit: |
e9001b4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b577501e.gmx-interface.pages.dev |
| Branch Preview URL: | https://alchemy-for-large-accounts.gmx-interface.pages.dev |
| const LARGE_ACCOUNT_CHAINS = [ARBITRUM, AVALANCHE]; | ||
|
|
||
| export function useAccountVolumeStats(params: { account?: string; enabled?: boolean }) { | ||
| const { account, enabled = true } = params; |
There was a problem hiding this comment.
enabled seems to be always true, you think it will be needed in the nearest future?
There was a problem hiding this comment.
Indeed, removed this props
src/lib/rpc/bestRpcTracker.ts
Outdated
| @@ -79,7 +83,7 @@ function trackRpcProviders({ warmUp = false } = {}) { | |||
| const hasMultipleProviders = Object.keys(providers).length > 1; | |||
| const isUnusedChain = | |||
| !lastUsage || differenceInMilliseconds(Date.now(), lastUsage) > DISABLE_UNUSED_TRACKING_TIMEOUT; | |||
| const isChainTrackingEnabled = (warmUp || !isUnusedChain) && hasMultipleProviders; | |||
| const isChainTrackingEnabled = !isLargeAccount && (warmUp || !isUnusedChain) && hasMultipleProviders; | |||
There was a problem hiding this comment.
I think this part of requirements wasn't implemented:
If paid RPC does not work, usual logic of RPC selection must be used (competitive selection, switching, etc, including free RPCs)
There was a problem hiding this comment.
My initial thought was that after the last ABs, we proved Alchemy is reliable and don't need this 'fallback for fallback.' However, after syncing with G, it became clear that it's better to do it.
Thank you for highlighting this point.
