#65 Relax docstring for executor in line with underlying HttpClient

gnarroway · Jun 29, 2024 · 3cef6a9 · 3cef6a9
1 parent 2632f31
commit 3cef6a9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/hato/client.clj b/src/hato/client.clj
@@ -218,7 +218,7 @@
   `cookie-handler` a java.net.CookieHandler
   `cookie-policy` :none, :all, :original-server. cookie-handler takes precedence if specified
   `connect-timeout` in milliseconds
-  `executor` a java.util.concurrent.ThreadPoolExecutor
+  `executor` a java.util.concurrent.Executor
   `redirect-policy` :never (default), :normal, :always
   `priority` an integer between 1 and 256 inclusive for HTTP/2 requests
   `proxy` a java.net.ProxySelector or :no-proxy

diff --git a/test/hato/client_test.clj b/test/hato/client_test.clj
@@ -75,7 +75,7 @@
     (let [executor (pexec/fixed-pool 1)
           client (build-http-client {:executor executor})
           stored-executor (.orElse (.executor client) nil)]
-      (is (instance? java.util.concurrent.ThreadPoolExecutor stored-executor) "executor has proper type")
+      (is (instance? java.util.concurrent.Executor stored-executor) "executor has proper type")
       (is (= executor stored-executor) "executor set properly")))
 
   (testing "ssl-context"