Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'aggregates' API endpoint (aggregates/measures distinguishing) #421

Open
9 tasks
Asu4ni opened this issue Oct 11, 2017 · 0 comments
Open
9 tasks

Add 'aggregates' API endpoint (aggregates/measures distinguishing) #421

Asu4ni opened this issue Oct 11, 2017 · 0 comments
Labels

Comments

@Asu4ni
Copy link
Contributor

Asu4ni commented Oct 11, 2017

Since in the document 'aggregates' have been distinguished from 'measures', the api should be slightly modified as well.
And maybe at the same time, due to the issue #307, the DELETE methed for 'aggregates' could be implemented as well.

Here is the todo list:

  • deprecate GET /v1/metric/<id>/measures
  • deprecate GET /v1/batch/metrics/measures
  • add GET /v1/metric/<id>/aggregates
  • add GET /v1/batch/metrics/aggregates
  • modify document to mention the changes
  • add release note of the additions and the deprecations

Here is the maybe one:

  • change the key value in content returned by 'groupby metric search' from measures to aggregates
  • add DELETE /v1/metric/<id>/aggregates to delete the processed aggregates. The range to delete can be limited by start and end parameter
  • change names in the code to aggregates if needed

If there are something missed or to be modified, please comment to let me know.

@Asu4ni Asu4ni changed the title Add 'aggregates' API endpoint Add 'aggregates' API endpoint (aggregates/measures distinguishing) Oct 13, 2017
@jd jd added the api label Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants