Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create or reuse a wallet connection standard and integrate it into Gnoweb #2799

Open
moul opened this issue Sep 13, 2024 · 3 comments
Open
Labels
🗺️good first issue🗺️ Ideal for newcomer contributors hacktoberfest This might be a good issue for a hacktoberfest participant to handle. help wanted Want to contribute? We recommend these issues.

Comments

@moul
Copy link
Member

moul commented Sep 13, 2024

The goal is to ensure that Gnoweb does not depend on any external resources or specific wallets (e.g., Adena). Instead, it should allow any wallet that understands this standard to intercept or inject themselves, making Gnoweb wallet-compatible if a wallet integration is available. If no wallet integration is present, Gnoweb should continue displaying copy-paste-friendly commands, and the page should load without issues.

Important Note:
Gnoweb is not just the frontend for our testnets, but the official frontend, including for local development. Therefore, it is crucial that it works without external dependencies, specific network configurations, or an internet connection.

Objectives:

  • Discuss and define the wallet connection standard.
  • Plan the integration of this standard into Gnoweb.
  • Ensure that Adena Wallet, Gnobro, and potentially other tools can implement this standard.

cc:

@AnhVAR
Copy link

AnhVAR commented Sep 13, 2024

I think to keep gnoweb not depend external lib we can add URL Scheme for Gnokey. It mean we can direct call Gnokey to get wallet address, sign, broadcast messgae by URL. @moul

@AnhVAR
Copy link

AnhVAR commented Sep 14, 2024

Url scheme will be standard for other wallet too. Right now chrome extention not support active by url scheme but any standanlone application on desktop or mobile can do it. User can select default wallet they want when we make standard for url scheme for gno wallet

@AnhVAR
Copy link

AnhVAR commented Sep 18, 2024

@moul i just make a draft standard for wallet. Take your time to see it. Thanks https://hackmd.io/@KFPb-646Qr-0raWlHDnSvQ/r11JNiPaC/edit.

@wyhaines wyhaines added the hacktoberfest This might be a good issue for a hacktoberfest participant to handle. label Sep 30, 2024
@Kouteki Kouteki added help wanted Want to contribute? We recommend these issues. and removed help wanted labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️good first issue🗺️ Ideal for newcomer contributors hacktoberfest This might be a good issue for a hacktoberfest participant to handle. help wanted Want to contribute? We recommend these issues.
Projects
Status: 📥 Inbox
Status: Triage
Development

No branches or pull requests

4 participants