-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC disable branch creation on origin #2821
Comments
My counter-argument is that branch creation on origin allows me to have "stacked" PRs. It's also the reason why I switched to developing on origin rather than my fork. This is an example of a stacked PR: #1700 So I can have dev/morgan/1, then dev/morgan/2 based on it, and then dev/morgan/3 based on /2. When 1 is merged; 2 is automatically re-based on master. If we use forks, we can only create these in the same forks. |
at the end of the day, there are hacks we can do to have more or less the same thing thehowl:dev/1 can have thehowl:dev/2 based on it. I can create a PR on gnolang:master for both, and put in the description of dev/2 that they can look at my own fork to see a nicer diff. Not ideal, but also something that other contributors can copy freely as a workflow. Sounds good to me, as long as we maintain the possibility for certain team-members to create "useful" branches on origin (like patch/gnochess and patch/v0.1.1-sync). |
I'm fine with allowing some exceptions, such as the long-term alternative base and things like the gnochess temp fork. |
I believe we should prevent people from creating branches on the origin remote (gnolang/gno) to encourage the use of external branches.
Why? There are three main reasons:
See https://github.com/gnolang/gno/branches/all
The text was updated successfully, but these errors were encountered: