-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feedback needed: how are you using gnoland genesis ...
?
#2824
Comments
Not much; but I personally haven't operated a node. I did find the I see a point in having commands to manipulate genesis files as compared to using genesis_txs and genesis_balances, which then get combined into a genesis file. These are not removed yet, but they should be. I wonder whether there should be some shared functionality, like the one that I doubt many, even among node operators, will need to use the genesis commands. Even #2841 is a glorified wget + sha256sum. @zivkovicmilos wdyt? |
I'll give my feedback here since I mostly designed the current genesis command suite I'm starting from the premise that a node operator does not need to be aware of different tools (binaries) in order to boostrap their blockchain deployment. It's pretty standard across the ecosystem to bundle chain building tools into the blockchain client binary, and release them with the binary (there are no 2 release streams for the client and helpers like these, but a single one, that always works). The historical reason why it's bundled is because it makes the lives of our DevOps friends x10 easier, when they need to fetch a single binary and orchestrate everything from it -- this binary is not used for a single step, but across workflows that can be as complex or as easy as you like. I do agree @moul that the CLI suite we have is a bit bloated, even though it's extremely useful (if we're looking for a CLI suite to tackle with the most impact on sanity, please see gnokey). I personally am very happy with the chain orchestration flow we have now in comparison with the past, and in comparison to what's standard in Cosmos today. There are a few legacy patches here and there that I'd love to remove (the files Morgan is mentioning are prime examples), we have some issues already opened. If the idea is to make the Removing
This is not really true, I invite the ops family (@sw360cab, @albttx, @mazzy89, @r3v4s, @D4ryl00 and others) to give their opinion on this discussion as well :) |
IMO it is useful to keep Probably in a testnet or mainnet scenario this is not the case. But when dealing with dev or staged environments that can be bootstrap from scratch, I found the command handy and useful. |
@sw360cab That makes two of us. Once we launch mainnet and after it gets stabilized, no need to do something with genesis. But for staging, it is very handy to keep it. |
Does anyone have a good reason not to move it to Else, we should do it asap, please. |
After discussing with Sergio, I'm a bit more convinced that they make sense to be kept in the That said, we could take 5 minutes at the retreat to come to a conclusion :) |
@thehowl I am available fro the 5 min "come to a conclusion" thing |
this, please. |
@moul can you state your case for moving them instead? especially since we have secrets and config already in okay, node operators on mainnet won't need it, but there'll still be testnets managed by us and partners, even after mainnet. |
For testnets, the situation is similar; someone will create a genesis so that node operators can simply use |
## Description This PR migrates the `gnoland genesis` command suite under `contribs/gnogenesis`, after following discussions from #2824, and internal discussions. **BREAKING CHANGE** `gnoland genesis` will cease to exist after this PR, instead, you will need to use the binary in `contribs/gnogenesis`. It's installed by default after running `make install` from the repo root. Closes #2824 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details>
I'm considering whether these commands should be included in the
gnoland
binary, placed elsewhere, or if they are necessary at all.I would appreciate feedback on how people are currently using these commands. If no one is using them yet, please explain how you envision using them in the future.
Additionally, if you're already using them and have suggestions for improvement, please share your thoughts.
The text was updated successfully, but these errors were encountered: