Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal loop CI testing against its genesis.json #2862

Open
thehowl opened this issue Sep 26, 2024 · 1 comment
Open

Portal loop CI testing against its genesis.json #2862

thehowl opened this issue Sep 26, 2024 · 1 comment

Comments

@thehowl
Copy link
Member

thehowl commented Sep 26, 2024

I don't think this one hit the mark: #2064

What we need is a CI check that downloads the current portal loop genesis.json and makes sure that no transactions that should succeed (ie. succeed in the current portal loop execution) start failing, were the PR to be merged.

@moul
Copy link
Member

moul commented Sep 27, 2024

We won't achieve a green CI with a breaking change, and we don't want to block such changes.

However, we do want to address the portal loop, which is a separate issue. Instead of implementing a CI check in the main repo for each PR, we should set up monitoring to easily notify us and provide a clear list of failing transactions on the production instances. This way, we can quickly identify and resolve issues in the history.

See #2867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants