-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples]: GRC20 underflow/overflow checking #2873
Comments
Can you please link the specific files you're talking about? |
I updated my comment. |
Thanks. I think the idea here was to check for underflow in the case of burn. |
I created this PR2874. |
Cool, I'll take a look. Thanks. In the future, please try to make your PRs & issues a bit more descriptive, so that the person reading it has the context needed to understand. This also applies to issue/PR names :) |
Description
@moul, I was checking the grc20 package, and in
banker.gno
file you put// TODO: check for overflow
in the Mint and Burn functions.I added the check in Mint function and added a test file.
but I don't see why (or how) to check for overflow in Burn function, as the check in Mint function is enough to protect from overflow.
The text was updated successfully, but these errors were encountered: