docs: Effective Gno #1000
Merged
docs: Effective Gno #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
force-pushed
the
dev/moul/effective-gno
branch
from
0a9fac1
to
d96c266
Compare
github-actions
bot
added
🧾 package/realm
moul
force-pushed
the
dev/moul/effective-gno
branch
from
77c66c0
to
cb8df8f
Compare
github-actions
bot
added
🧾 package/realm
moul
force-pushed
the
dev/moul/effective-gno
branch
from
cb8df8f
to
e49b255
Compare
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
moul
force-pushed
the
dev/moul/effective-gno
branch
from
e49b255
to
a9359c0
Compare
github-actions
bot
removed
🧾 package/realm
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com> Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Morgan <git@howl.moe>
7 tasks
1 task
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
mvertes
reviewed
Feb 1, 2024
There was a problem hiding this comment.
This guide looks good to me and is extremely useful.
To go further, it would be also useful to have pointers on grc20 or grc721 reference documents, and other important concept documents about smart contracts, if they exist. The same for relevant security practices. I'm always found of a solid bibliography which enhances the quality a lot.
Co-authored-by: Marc Vertes <mvertes@free.fr>
thehowl
approved these changes
Feb 1, 2024
|
Pending @leohhhn review, if all's good we can merge afterwards! |
3 tasks
leohhhn
approved these changes
Feb 2, 2024
Closed
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
leohhhn
approved these changes
Feb 8, 2024
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
|
MERGING! |
leohhhn
added a commit
to leohhhn/gno
that referenced
this pull request
Feb 8, 2024
I'm working towards a concise style, suggesting an initial review of [Effective Go](https://go.dev/doc/effective_go), followed by Gno-specific practices. I'm also considering making code snippets in this documentation unit-testable. --------- Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com> Signed-off-by: moul <94029+moul@users.noreply.github.com> Co-authored-by: jon roethke <waymobetta@users.noreply.github.com> Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com> Co-authored-by: Morgan <git@howl.moe> Co-authored-by: Marc Vertes <mvertes@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working towards a concise style, suggesting an initial review of Effective Go, followed by Gno-specific practices. I'm also considering making code snippets in this documentation unit-testable.