-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add test to demonstrate PrevRealm var block bug #1079
Conversation
Signed-off-by: Norman Meier <norman@berty.tech>
|
||
func TestVarPrevRealm(t *testing.T) { | ||
if initRealm.Addr() != varRealm.Addr() { | ||
t.Errorf("initRealm != varRealm") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the issue and the PR, it would be nice if your test reports something like
t.Errorf("initRealm != varRealm") | |
t.Errorf("expect initRealm '%s' to be equal to varRealm '%s'", initRealm.Addr(), varRealm.Addr() ) |
Same for following t.Errorf
, thanks in advance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Norman Meier <norman@berty.tech>
…broken Signed-off-by: Norman Meier <norman@berty.tech>
I put some logs in I assume it's something that needs to be fixed in the gnovm, so probably a little tricky! |
@tbruyelle do you think we can use the txtar stuff for storing known bugs in the repo somewhere? |
Ideally it should go to Else txtar can be used also, it just need a proper setup for this kind of bugs. |
if other challenges realms are available I could add two realms in challenges |
I'm not sure you can interact with more than one realm in the challenges, but maybe that's possible. The code is in |
closing as #941 has been resolved. |
This adds a test to demonstrate the PrevRealm bug in var block outlined in #941
BREAKING CHANGE: xxx
message was included in the description