Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gnoffee PoC #1092

Closed
wants to merge 5 commits into from
Closed

feat: add gnoffee PoC #1092

wants to merge 5 commits into from

Conversation

moul
Copy link
Member

@moul moul commented Sep 3, 2023

I'm pondering a few things about our setup:

  1. Where's the best spot for the package: misc/, gnovm/, new top-level namespace, or its own repo?
  2. Should this be a standalone command or a part of gno?
  3. Right now, the command processes .gnoffee files and gives us output. You can see it on screen or save it using -w. But here's the twist: it currently blends the new bits with all the .gnoffee scripts, creating a full .go file. Another idea is to just pinpoint and add what's missing, resulting in a gnoffee.gen.go file. I'm weighing up both approaches and would appreciate your insights.

Any feedback or even a chat about it would be great. cc @gnolang/tech-staff @gnolang/core-contributors

Suggestion for reviewers: checkout the txtar tests: https://github.com/gnolang/gno/pull/1092/files#diff-a9299fce0ae91a6a0eb6e0bfc51ab83a51116d452703e4c82f473f1e933dff4f

Addresses gnolang/hackerspace#22
Addresses #1075
Depends on #1093 (tests fail on go1.19)

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@moul moul self-assigned this Sep 3, 2023
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Sep 3, 2023
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
Copy link
Member Author

moul commented Sep 4, 2023

A next step would be to add support for *int128,256

@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023
moul added a commit to gnoverse/gnoffee that referenced this pull request Sep 10, 2023
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul mentioned this pull request Sep 10, 2023
@moul
Copy link
Member Author

moul commented Sep 10, 2023

Will continue here -> gnoverse/gnoffee#1

@moul moul closed this Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: ✅ Done
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant