Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: p/subscription #2116

Merged
merged 17 commits into from
Aug 22, 2024
Merged

feat: p/subscription #2116

merged 17 commits into from
Aug 22, 2024

Conversation

kazai777
Copy link
Contributor

I've created this subscription package based on this PR from @moul, I've integrated two types of subscription, a recurring payment subscription and a lifetime subscription. Do you have any ideas for other types of subscription that would be relevant to this package?

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@kazai777 kazai777 requested review from a team as code owners May 15, 2024 14:17
@kazai777 kazai777 requested review from petar-dambovaliev and harry-hov and removed request for a team May 15, 2024 14:17
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label May 15, 2024
@kazai777
Copy link
Contributor Author

kazai777 commented Jun 6, 2024

Hi @petar-dambovaliev @harry-hov , can you give me a review when you have time please? Is there anything else I can do to make the review easier for you?

Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
@zivkovicmilos zivkovicmilos requested review from zivkovicmilos and removed request for petar-dambovaliev and harry-hov August 15, 2024 09:23
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the package 🙏

I've left some comments alongside @moul, because I think we can make this even better

examples/gno.land/p/demo/subscription/subscription.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/subscription/subscription.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/subscription/subscription.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/subscription/subscription.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/subscription/subscription.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/subscription/subscription.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/subscription/subscription.gno Outdated Show resolved Hide resolved
@zivkovicmilos
Copy link
Member

@kazai777 can you please check why the CI is failing? 🙏

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.22%. Comparing base (04d5239) to head (53e11f6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2116      +/-   ##
==========================================
- Coverage   60.23%   60.22%   -0.01%     
==========================================
  Files         562      562              
  Lines       75091    75091              
==========================================
- Hits        45230    45223       -7     
- Misses      26481    26486       +5     
- Partials     3380     3382       +2     
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 64.76% <ø> (ø)
gnovm 64.33% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.03% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kazai777
Copy link
Contributor Author

@kazai777 can you please check why the CI is failing? 🙏

I've fixed the various problems and the CI .

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for applying the suggestions 🙏

This now looks super clean 😎

@zivkovicmilos zivkovicmilos merged commit c8e717a into gnolang:master Aug 22, 2024
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants