-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: p/subscription #2116
feat: p/subscription #2116
Conversation
Hi @petar-dambovaliev @harry-hov , can you give me a review when you have time please? Is there anything else I can do to make the review easier for you? |
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the package 🙏
I've left some comments alongside @moul, because I think we can make this even better
@kazai777 can you please check why the CI is failing? 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2116 +/- ##
==========================================
- Coverage 60.23% 60.22% -0.01%
==========================================
Files 562 562
Lines 75091 75091
==========================================
- Hits 45230 45223 -7
- Misses 26481 26486 +5
- Partials 3380 3382 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I've fixed the various problems and the CI . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for applying the suggestions 🙏
This now looks super clean 😎
I've created this
subscription
package based on this PR from @moul, I've integrated two types of subscription, a recurring payment subscription and a lifetime subscription. Do you have any ideas for other types of subscription that would be relevant to this package?Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description