-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnoweb): source code viewer improvements #2757
base: master
Are you sure you want to change the base?
feat(gnoweb): source code viewer improvements #2757
Conversation
So far, I have added a line counter but I don't really see how we can achieve a permalink as we sanitize the html removing all onclick attributes so we cannot really do simple highlighting logic + copying permalink |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2757 +/- ##
==========================================
+ Coverage 60.84% 60.86% +0.01%
==========================================
Files 563 563
Lines 75190 75190
==========================================
+ Hits 45753 45766 +13
+ Misses 26068 26057 -11
+ Partials 3369 3367 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey, checked out gnoweb with this PR. Seems that the import links only work for the first link in the series. Take a look and see if you can fix this. Also, it would be great if the imports weren't constantly underlined, but only upon mouse hover. |
Hello @leohhhn I have fixed the import of link only for the first + implemented the style overhaul you suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. Some work needed; let's focus on the esthetical changes for now and we can tackle the imports at a later time.
Removed the "review team" label because this is already reviewed by core devs. |
Improve the source code viewer with several changes:
closes #2746
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description