feat: change gnoweb to add URL query arguments to render path
#2876
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeronimoalbi
added
🌍 gnoweb
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2876 +/- ##
==========================================
- Coverage 60.91% 60.91% -0.01%
==========================================
Files 564 564
Lines 75273 75283 +10
==========================================
+ Hits 45855 45856 +1
- Misses 26047 26055 +8
- Partials 3371 3372 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jeronimoalbi
commented
Oct 1, 2024
| filtered := url.Values{} | ||
| for k, v := range values { | ||
| // Filter out private gnoweb arguments | ||
| if strings.HasPrefix(k, "__") { |
There was a problem hiding this comment.
Checking __ to allow _ prefix to users but otherwise checking _ should be done.
The "help" parameter is allowed to be pass to the render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.