-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnovm): returns error as Go when assignment with a function which does not return any value #3049
Draft
hthieu1110
wants to merge
19
commits into
gnolang:master
Choose a base branch
from
hthieu1110:feat/cryptic-error-func-return-0-value-1082
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(gnovm): returns error as Go when assignment with a function which does not return any value #3049
hthieu1110
wants to merge
19
commits into
gnolang:master
from
hthieu1110:feat/cryptic-error-func-return-0-value-1082
+260
−192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mikael VALLENET <mikael.vallenetpro@gmail.com>
…ed value function
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3049 +/- ##
==========================================
- Coverage 63.11% 63.10% -0.01%
==========================================
Files 548 548
Lines 78514 78486 -28
==========================================
- Hits 49553 49530 -23
+ Misses 25616 25612 -4
+ Partials 3345 3344 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hthieu1110
changed the title
Feat/cryptic error func return 0 value 1082
feat(gnovm): returns error as Go when assignment with a function which does not return any value
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at resolving this issue: #1082
This depends on #3017 because it refactored the code to sync the logic/code between AssignStmt vs ValueDecl.
Related #2695
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description