Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnovm): returns error as Go when assignment with a function which does not return any value #3049

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

hthieu1110
Copy link
Contributor

@hthieu1110 hthieu1110 commented Oct 30, 2024

This PR aims at resolving this issue: #1082

This depends on #3017 because it refactored the code to sync the logic/code between AssignStmt vs ValueDecl.

Related #2695

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.10%. Comparing base (ed91991) to head (2460630).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/preprocess.go 95.74% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
- Coverage   63.11%   63.10%   -0.01%     
==========================================
  Files         548      548              
  Lines       78514    78486      -28     
==========================================
- Hits        49553    49530      -23     
+ Misses      25616    25612       -4     
+ Partials     3345     3344       -1     
Flag Coverage Δ
contribs/gnodev 60.57% <ø> (ø)
gno.land 63.82% <ø> (ø)
gnovm 67.86% <95.74%> (-0.02%) ⬇️
misc/genstd 79.72% <ø> (ø)
tm2 62.41% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hthieu1110 hthieu1110 changed the title Feat/cryptic error func return 0 value 1082 feat(gnovm): returns error as Go when assignment with a function which does not return any value Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: No status
Status: Triage
Development

Successfully merging this pull request may close these issues.

1 participant