Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): mirror realm #3156

Merged
merged 3 commits into from
Nov 19, 2024
Merged

feat(examples): mirror realm #3156

merged 3 commits into from
Nov 19, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Nov 19, 2024

Description

Adds the mirror realm.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 19, 2024
@leohhhn leohhhn requested review from moul and gfanton November 19, 2024 08:52
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.78%. Comparing base (1e2929b) to head (a7aa0e9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3156      +/-   ##
==========================================
- Coverage   63.81%   63.78%   -0.04%     
==========================================
  Files         549      549              
  Lines       78833    78833              
==========================================
- Hits        50308    50282      -26     
- Misses      25136    25158      +22     
- Partials     3389     3393       +4     
Flag Coverage Δ
contribs/gnodev 61.16% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (-0.95%) ⬇️
gno.land 73.70% <ø> (ø)
gnovm 67.94% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.28% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ltzmaxwell
Copy link
Contributor

this can reflect recursively like two mirrors infinitely, right?

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever :)

@leohhhn
Copy link
Contributor Author

leohhhn commented Nov 19, 2024

@ltzmaxwell

Yep, but since you cannot pass in an argument to the Render function that was registered, it will not go into deep recursion

@moul

Idea was @jeronimoalbi's, all credits to him

@leohhhn leohhhn merged commit b3800b7 into gnolang:master Nov 19, 2024
135 checks passed
@leohhhn leohhhn deleted the mirror branch November 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants