chore: Remove getActiveAccount usage #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuricmp
force-pushed
the
chore/remove-get-active-account
branch
from
b23941c to
fb24e7d
Compare
jefft0
force-pushed
the
chore/remove-get-active-account
branch
from
fb24e7d to
e94dc7a
Compare
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
…ider setAccount. Signed-off-by: Jeff Thompson <jeff@thefirst.org>
jefft0
force-pushed
the
chore/remove-get-active-account
branch
from
e94dc7a to
b314c9e
Compare
…in setPassword Signed-off-by: Jeff Thompson <jeff@thefirst.org>
…ount Signed-off-by: Jeff Thompson <jeff@thefirst.org>
…ch target This is the same fix as PR gnoverse/dsocial#134 Signed-off-by: Jeff Thompson <jeff@thefirst.org>
jefft0
force-pushed
the
chore/remove-get-active-account
branch
from
b314c9e to
312fd47
Compare
iuricmp
approved these changes
Oct 10, 2024
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PR gnoverse/dsocial#130, we update gnoboard to use the new Gno Native Kit API which removes
selectAccountand requires passing the account address tosetPassword, etc. This PR has five commits:GnoboardProvider.selectAccount, callGnoboardProvidersetAccountto remember the active account.setPasswordneeds the account address, so inReenterPasswordadd paramaccountAddress.getActiveAccount. Use the account address to callqueryAccount.With this PR, all known apps have been updated to remove
selectAcountand to pass the account address to the methods of Gno Native Kit, which can be updated to remove deprecated functions and to make the address not optional.