Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secondary indexes + querying tx by hash #16

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

ajnavarro
Copy link
Collaborator

Sadly, I had to encode hashes using base64 instead of base16 to keep
compatibility with other places where we are showing the hash as base64
to the user...

  • BREAKING CHANGE: The indexer database has to be re-fetched to apply the secondary index by hash.

Signed-off-by: Antonio Navarro Perez antnavper@gmail.com

@ajnavarro ajnavarro requested a review from a team as a code owner March 13, 2024 12:31
@thehowl thehowl changed the title Added primary indexes and GraphQL interface: feat: add secondary indexes + querying tx by hash Mar 14, 2024
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

Base automatically changed from feature/indexes-on-storage to main March 18, 2024 10:45
Sadly, I had to encode hashes using base64 instead of base16 to keep
compatibility with other places where we are showing the hash as base64
to the user...

- BREAKING CHANGE: The indexer database has to be re-fetched to apply the secondary index by hash.

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro merged commit 66368d8 into main Mar 18, 2024
3 checks passed
@ajnavarro ajnavarro deleted the feature/secondary-indexes branch March 18, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants