Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rollback backward incompatible change #91

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

ajnavarro
Copy link
Collaborator

@ajnavarro ajnavarro commented Sep 11, 2024

Rollback field name changed here: #74
Also Rollback #84

GraphQL supports slices of one element without adding brackets. Examples:

{
  transactions(filter: {message: [{vm_param: {add_package: {}}}]}) {
    hash
    messages {
      route
      typeUrl
    }
  }
}
{
  transactions(filter: {message: {vm_param: {add_package: {}}}}) {
    hash
    messages {
      route
      typeUrl
    }
  }
}

These two queries are the same.

CC @moul @zivkovicmilos @jinoosss we must avoid breaking backward compatibility in our API.

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro merged commit 220501c into main Sep 13, 2024
4 checks passed
@ajnavarro ajnavarro deleted the fix/messages-to-message-breaking-api branch September 13, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants