Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: genesis transaction marshaling #96

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: genesis transaction marshaling #96

merged 3 commits into from
Oct 1, 2024

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Sep 30, 2024 •
edited
Loading

Genesis transaction are encoded using amino.MarshalJSON where the graphql resolver uses amino.Unmarshal (not json)

Before: (Tx messages missing)
Screenshot 2024-09-30 at 15 31 14

After: (Tx messages returned)
Screenshot 2024-09-30 at 15 29 45

@n0izn0iz
fix: genesis transaction marshalling
6be8d31 
Signed-off-by: Norman Meier <norman@samourai.coop>
@n0izn0iz n0izn0iz requested a review from a team as a code owner September 30, 2024 13:28
@n0izn0iz n0izn0iz changed the title fix: genesis transaction marshalling fix: genesis transaction marshaling Sep 30, 2024
zivkovicmilos
zivkovicmilos approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 💯

This actually slipped during the initial PR, and PR review. Transactions in blocks are always encoded as pure amino binary, not JSON

Thank you for the fix 🙏

@zivkovicmilos zivkovicmilos merged commit 124725d into gnolang:main Oct 1, 2024
4 checks passed
@zivkovicmilos zivkovicmilos deleted the fix-genesis-tx-marshal branch October 1, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@deelawn deelawn Awaiting requested review from deelawn deelawn was automatically assigned from gnolang/tech-staff

Assignees

@n0izn0iz n0izn0iz

Labels
None yet
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n0izn0iz @zivkovicmilos