Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly mention that version is untracked in Cargo.toml #41

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Explicitly mention that version is untracked in Cargo.toml #41

wants to merge 3 commits into from

Conversation

fedgiac
Copy link

@fedgiac fedgiac commented Nov 28, 2022 •
edited
Loading

The version number was lagging behind and no one depends on this version number. This change makes this fact explicit.

Thanks Martin for the suggestion.

@fedgiac fedgiac requested a review from MartinquaXD November 28, 2022 10:32
MartinquaXD
MartinquaXD reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since nobody depends on that package could we maybe drop the version field to not have to worry about keeping that synchronized?

@fedgiac fedgiac changed the title Bump version to v0.18.0 Explicitly mention that version is untracked in Cargo.toml Nov 28, 2022
@fedgiac
Copy link
Author

fedgiac commented Nov 28, 2022

It can't be removed (or be something that isn't semver), so I reset the version to 0 and added a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinquaXD MartinquaXD MartinquaXD left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedgiac @MartinquaXD