Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DeployableTraderAgent to 1. predict a probability for a market then 2. place a bet based on its
BettingStrategy
#352Refactor DeployableTraderAgent to 1. predict a probability for a market then 2. place a bet based on its
BettingStrategy
#352Changes from 35 commits
7f6c0a7
626c42d
ed21ffd
faf35e2
a4fc8c9
d51301e
bcbe375
7bbb0c5
74da0d1
01ba8f2
d6f4b14
1ae480a
4515bdd
f073fb8
14c9250
0c8bf96
9e85c79
4432d3b
683b95f
c013ee2
080ec6e
cc25098
99d1eee
0fcd66d
fc97df9
8dce9ce
82bd7b9
913be0c
a033c5e
932cfa2
6e66394
742db1d
c2cf786
0b886fb
45f9545
0e9386a
9eb4140
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change from a
YES
enum to a boolean required?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed in another thread (can't remember which one from the 80 comments) - if you have specific concerns, happy to open a new PR to discuss having "YES" or True.