-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate AgentMarket.outcome_token_pool into betting strategies #389
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9bbf51f
Integrate AgentMarket.outcome_token_pool into betting strategies
evangriffiths 29ab1cf
fix
evangriffiths 68a4356
fix
evangriffiths e095b27
Review comment
evangriffiths 111b3ce
Remove breakpoint
evangriffiths d7de8b6
Merge main
evangriffiths 5d5a681
Add sanity check to tests
evangriffiths d6f9005
Update prediction_market_agent_tooling/deploy/betting_strategy.py
evangriffiths d50c553
mypy
evangriffiths 745bd1c
fix
evangriffiths 2038282
tidy
evangriffiths 368c1af
Make market-moving bet more precise
evangriffiths 43b4b97
Add zero-bet test
evangriffiths e5fcd68
Merge branch 'main' into evan/kelly-bet-full
evangriffiths 55159fb
Merge branch 'main' into evan/kelly-bet-full
evangriffiths d2818ba
Add util function OmenAgentMarket.get_new_p_yes
evangriffiths a54abbe
Add OmenAgentMarket.get_buy_token_amount util function
evangriffiths File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question about the formula: if (x=yes_outcome_pool_size = 10, y=no_outcome_pool_size=10), this always goes to 0 thus
bet_amount
is hard-set to 0.Is that correct? This would e.g. prevent us from placing bets in balanced markets using Kelly - but maybe I'm mistaken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that doesn't seem like desirable behaviour! Have made an issue to fix: #401